Relax atomic loads and stores in Table
#766
Open
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbarsky here is your reminder for this for your loom work |
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #766 will not alter performanceComparing Summary
|
Veykril
force-pushed
the
veykril/push-qryuyllyzoll
branch
2 times, most recently
from
eeb899a to
0b2a614
Compare
The allocation lock already enforces a happens-before relationship for the initialized length
Veykril
force-pushed
the
veykril/push-qryuyllyzoll
branch
from
0b2a614 to
45eaab3
Compare
I don't think shuttle actually models weak atomics. We could run Miri with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already paired with a lock-access on write.
just shuttlepasses