clean up usage of null/undefined #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily allowing either value for user input.
colincasey
requested changes
Mar 14, 2024
colincasey
previously approved these changes
Mar 15, 2024
wjhsf
commented
Mar 19, 2024
colincasey
reviewed
Mar 21, 2024
colincasey
reviewed
Mar 21, 2024
colincasey
reviewed
Mar 21, 2024
wjhsf
commented
Mar 21, 2024
Apply suggestions from code review Co-authored-by: Colin Casey <[email protected]>
colincasey
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes most of our methods to accept both null and undefined, and mostly return a value or undefined. Exceptions that I noticed are
canonicalDomain,getPublicSuffix,permuteDomain, anddomainMatch, which all return null. I don't remember why I skipped them when I originally did this, so I figured I'd just leave them for now. (I did most of this work a while ago, and evidently never pushed!)This also introduces a helper type
Nullable<T>for readability.nb: #377 but without changes to cookie creation