Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up usage of null/undefined #377

Closed
wants to merge 13 commits into from
Closed

clean up usage of null/undefined #377

wants to merge 13 commits into from

Commits on Nov 5, 2023

  1. Avoid using void.

    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    6056bbc View commit details
    Browse the repository at this point in the history

  2. Avoid using no-op callback. 

    Instead, change `putCookie` invocation depending on whether `callback` is provided.
    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    f5608fd View commit details
    Browse the repository at this point in the history

  3. Misc cleanup.

    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    030e176 View commit details
    Browse the repository at this point in the history

  4. Prefer promiseCallback.resolve where possible. 

    `promiseCallback.resolve()` is implemented as `cb(); return promise`,
so doing `promiseCallback.callback(); return promiseCallback.promise`
is unnecessary.
    @wjhsf
    wjhsf committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    09d2433 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Make usage of null/undefined more consistent. 

    Primarily allowing either value for user input.
    @wjhsf
    wjhsf committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    73352da View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'master' into null-undefined

    @wjhsf
    wjhsf committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    964a495 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge branch 'master' into null-undefined

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    aecf15f View commit details
    Browse the repository at this point in the history

  2. fix bad merge

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    06cf3ee View commit details
    Browse the repository at this point in the history

  3. add explicit return type to canonicalDomain

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2530b43 View commit details
    Browse the repository at this point in the history

  4. add note for weird parse behavior

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    9bf5e80 View commit details
    Browse the repository at this point in the history

  5. Use only null for unset cookie props

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f94dcc1 View commit details
    Browse the repository at this point in the history

  6. Clean up cookie creation options.

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    443931c View commit details
    Browse the repository at this point in the history

  7. oops, missed a prop

    @wjhsf
    wjhsf committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e57831f View commit details
    Browse the repository at this point in the history