Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compress data backup using zstd #264

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

dlipovetsky
Copy link
Contributor

The backup turns out to be highly compressible!

I chose zstd. Although gzip is standard, zstd is faster, and compresses better.

Example:

4.6M sloop-cluster-0.bak.zst
9.5M sloop-cluster-0.bak.gz
155M sloop-cluster-0.bak

This introduces a dependency on module github.com/klauspost/compress, which contains a pure Go zstd implementation, so it can be used whether sloop is built with CGO enabled or disabled.

The backup turns out to be highly compressible!

I chose zstd. Although gzip is standard, zstd is faster, and compresses
better.

Example:

4.6M sloop-cluster-0.bak.zst
9.5M sloop-cluster-0.bak.gz
155M sloop-cluster-0.bak
Copy link
Collaborator

@annelau21 annelau21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@annelau21 annelau21 merged commit d66e65b into salesforce:master Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants