Add GHA workflow to lint helm chart, and fix a bug in the chart #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid apiGroup values, e.g. '*.mygroup.example.com', must be quoted in the template. Before this change, helm lint failed with this error: [ERROR] templates/clusterrole.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 92: did not find expected alphabetic or numeric character
|
Thanks for the contribution! Before we can merge this, we need @dlipovetsky to sign the Salesforce Inc. Contributor License Agreement. |
|
I signed the CLA, but it looks like the service had some internal error. |
sana-jawad
approved these changes
May 18, 2023
|
Looks good to me. Thanks for the contribution @dlipovetsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid apiGroup values, e.g.
*.mygroup.example.com, must be quoted in the template.Before this change,
helm lintfailed with this error:[ERROR] templates/clusterrole.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 92: did not find expected alphabetic or numeric characterAdds an action to lint the helm chart whenever it is changed.
Note: I've fixed the helm version at 3.12.0. If you'd like to always use the latest stable version, the action will need to use a GitHub token, as explained here: https://github.com/Azure/setup-helm#example