Skip to content

Commit

Permalink
fix: Quote ClusterRole apiGroups values in helm Chart
Browse files Browse the repository at this point in the history
Valid apiGroup values, e.g. '*.mygroup.example.com', must be quoted in
the template.

Before this change, helm lint failed with this error:

[ERROR] templates/clusterrole.yaml: unable to parse YAML: error
converting YAML to JSON: yaml: line 92: did not find expected alphabetic
or numeric character
  • Loading branch information
dlipovetsky committed May 18, 2023
1 parent bf1b9dd commit d331498
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion helm/sloop/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ rules:
{{- with .Values.clusterRole.apiGroups }}
- apiGroups:
{{- range . }}
- {{ . }}
- {{ . | quote }}
{{- end }}
resources:
- '*'
Expand Down

0 comments on commit d331498

Please sign in to comment.