Handle case where an error occurs of any type when attempting to get page layout for missing objects. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, user can at least see an issue, otherwise it was just silently failing without any notice.
sfdctaka
reviewed
Feb 20, 2024
| }); | ||
| } | ||
|
|
||
| static async checkForExistingQuickActions(): Promise<SObjectQuickActionStatus> { | ||
| return new Promise<SObjectQuickActionStatus>(async (resolve) => { | ||
| const results: SObjectQuickActionStatus = { sobjects: {} }; | ||
| return new Promise<SObjectQuickActionStatus>( |
There was a problem hiding this comment.
It looks like only the formatting changed. Was it by running prettier?
There was a problem hiding this comment.
This file changed mostly because of prettier, but also because the lines grew in length some because I added the reject block to the Promise.
maliroteh-sf
approved these changes
Feb 20, 2024
dbreese
force-pushed
the
handle-sobject-dne
branch
from
7d9dc1f
to
911baf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@khawkins @maliroteh-sf @sfdctaka