Getting Org connection from Salesforce Extensions services #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khawkins
commented
Nov 29, 2023
| const getWorkspaceDirStub = sinon.stub( | ||
| WorkspaceUtils, | ||
| 'getStaticResourcesDir' | ||
| ); | ||
| getWorkspaceDirStub.returns(Promise.resolve('.')); |
There was a problem hiding this comment.
This approach was breaking for me locally. Always dicey to use . as a working directory, as it's hard to know where the code is executed from. Moved to creating a temporary directory for this I/O.
khawkins
commented
Nov 29, 2023
| @@ -13,37 +13,51 @@ import { | |||
| NoWorkspaceError, | |||
| WorkspaceUtils | |||
| } from '../../../utils/workspaceUtils'; | |||
| import { TempProjectDirManager } from '../../TestHelper'; | |||
| import { | |||
There was a problem hiding this comment.
All of the changes in this file are just refactors to optimize the existing code. No new testing here, otherwise.
khawkins
commented
Nov 29, 2023
| @@ -48,8 +49,8 @@ export type SObjectCompactLayout = { | |||
| export class OrgUtils { | |||
| public static async getSobjects(): Promise<SObject[]> { | |||
| try { | |||
| const org = await Org.create(); | |||
| const conn = org.getConnection(); | |||
| const conn = | |||
There was a problem hiding this comment.
Changes in this file represent the entry points for the heart of the changes. Most of the other changes were either in the implementation of the backing Salesforce Extensions service connector code, or the supporting code in the tests.
dbreese
approved these changes
Nov 29, 2023
maliroteh-sf
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tacks to a design pattern recommended by the Salesforce Extensions team, for consuming the services that their extension exports for Org-based administration, connections, etc. With the previous implementation, we weren't successfully able to bootstrap a connection to the user's default Org, for retrieving sObject metadata.