Prettier html #54
Merged
Prettier html #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If approved I will merge this after @dbreese 's code generation PR is merged. |
khawkins
reviewed
Nov 15, 2023
package.json
Outdated
| "prettier:write": "prettier --write \"src/**/*.{ts, js}\"", | ||
| "prettier:verify": "prettier --list-different \"src/**/*.{ts, js}\"", | ||
| "prettier:write": "prettier --write \"src/**/*.{ts, js}\" \"resources/instructions/**/*.html\"", | ||
| "prettier:verify": "prettier --list-different \"{src, resources/instructions}/**/*.{ts, js}\" \"resources/instructions/**/*.html\"", |
There was a problem hiding this comment.
Nit: shouldn't the --list-different and --write arguments look basically the same? Specifically, should we pick one or the other of \"src/**/*.{ts, js}\" and \"{src, resources/instructions}/**/*.{ts, js}\", for consistency?
(And I'd lobby for the former, just because it's easier to read.)
khawkins
approved these changes
Nov 15, 2023
sfdctaka
force-pushed
the
htmlPrettier
branch
from
f4a5723
to
2eeb69d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.