Checks for a list of sobjects and the corresponding create/edit/view qa directories. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate/edit/view qa directories. May require some tweaking during integration, but this should be a good stepping stone.
|
Hmmm, not sure why "templateChooserCommand" test is failing. |
|
Appears to possibly be a flapper. I just re-ran the failed test and it passed with no issues, so we can keep an eye on ie. |
…nstead of INTERFACES.
dbreese
commented
Nov 7, 2023
| @@ -1,81 +1,110 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Sorry, most of the changes is just the addition of the scripts in the html. I made mistake of reformatting doc without realizing.
dbreese
commented
Nov 7, 2023
| </html> | ||
| }); | ||
|
|
||
| // Wait until all scripts are loaded, before engaging with e.g. |
There was a problem hiding this comment.
This is the meat of the change here -- makes a call to new function and dynamically generates table rows.
dbreese
commented
Nov 7, 2023
| type: 'getQuickActionStatus', | ||
| action: async (_panel, data, callback) => { | ||
| // TODO: Hook this up to function from W-14439417 that parses landing_page.json. | ||
| const sobjects = [ |
There was a problem hiding this comment.
Just a hard-coded list for now.
dbreese
changed the title
khawkins
reviewed
Nov 7, 2023
khawkins
reviewed
Nov 7, 2023
khawkins
reviewed
Nov 7, 2023
khawkins
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May require some tweaking during integration, but this should be a good stepping stone.
@sfdctaka @khawkins @maliroteh-sf