Upgrade dependencies to latest #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliroteh-sf
commented
Oct 26, 2023
| @@ -53,36 +53,36 @@ | |||
| "test-coverage": "node ./out/test/runTest.js --coverage", | |||
| "prettier:write": "prettier --write \"src/**/*.{ts, js}\"", | |||
| "prettier:verify": "prettier --list-different \"src/**/*.{ts, js}\"", | |||
| "bundle:extension": "esbuild ./src/extension.ts --bundle --outdir=out --format=cjs --target=es2020 --platform=node --external:vscode --external:@oclif/core --minify --sourcemap", | |||
| "bundle:extension": "esbuild ./src/extension.ts --bundle --outdir=out --format=cjs --target=es2020 --platform=node --external:vscode --external:@oclif/core --external:@salesforce/lwc-dev-mobile-core --minify --sourcemap", | |||
There was a problem hiding this comment.
Starting with v3.2.0 of lwc-dev-mobile-core, it has upgraded its dependency on @salesforce/core from 3.x to 5.x This seems to have changed the behavior of @salesforce/core around loading message files for loggers.
Since we're creating a bundle, if we don't exclude lwc-dev-mobile-core then it won't be able to load its message files. This is b/c lwc-dev-mobile-core has code like Messages.importMessagesDirectory(__dirname); but if it is being bundled, then wrong value will be used for __dirname (value would be the path to the extension root dir rather than the path to the dependency root dir in node_modules)
khawkins
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.