Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install package, to use vsce dependency for publish #36

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

khawkins
Copy link
Collaborator

@khawkins khawkins commented Jul 6, 2023

I noticed in the publish flow that npx vsce publish downloaded and installed vsce (and complained about not using its full package name), because we weren't installing the package dependencies of the project.

@khawkins khawkins requested a review from a team as a code owner July 6, 2023 00:17
@khawkins
Copy link
Collaborator Author

khawkins commented Jul 6, 2023

(Foregoing a version bump, since the change is entirely outside the package. This can get pulled into the next release.)

Copy link
Collaborator

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khawkins khawkins merged commit 6c0f45f into salesforce:main Jul 6, 2023
8 checks passed
@khawkins khawkins deleted the update_publish branch July 6, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants