GHA to publish VSIX package #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a high level, this manual workflow goes like this:
|
dbreese
reviewed
Jun 30, 2023
| throw new Error(`'${tagNameValue}' is not a valid version string.`); | ||
| } | ||
|
|
||
| // Put the 'v' back on, as our release tags are formatted as 'v'x.y.z. |
Changed naming, PAT access to look more like salesforcedx-vscode's. Cf. https://github.com/forcedotcom/salesforcedx-vscode/blob/develop/.github/workflows/publishVSCode.yml
gbockus-sf
reviewed
Jun 30, 2023
| env: | ||
| VSCE_PERSONAL_ACCESS_TOKEN: ${{ secrets.VSCE_PERSONAL_ACCESS_TOKEN }} | ||
| run: | | ||
| npx vsce publish -p ${{ env.VSCE_PERSONAL_ACCESS_TOKEN }} --packagePath ${{ steps.get_package_name.outputs.result }} |
There was a problem hiding this comment.
heh... a lot of this GHA flow is new to me...so LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to test the final (publishing) step, for obvious reasons. But I've tested the rest, by substituting the final step with a step that unzips the downloaded package and lists its contents, ensuring that we are in fact downloading a valid package from our release.