Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning dev is breaking vsce packaging #33

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

khawkins
Copy link
Collaborator

The size of the bundle doesn't change, and doing the dev pruning is otherwise breaking vsce when installed as a dev dependency.

Let's save the file culling for when we optimize the package.

@khawkins khawkins requested a review from a team as a code owner June 30, 2023 00:36
Copy link
Collaborator

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbreese
Copy link
Collaborator

dbreese commented Jun 30, 2023

Interesting, I was seeing it change in sizes, so perhaps it was something different causing the file to change sizes.

@dbreese
Copy link
Collaborator

dbreese commented Jun 30, 2023

Yip, you are correct, sir! Not sure what else I was seeing, but maybe it was a combination of trying the -external:* parms on esbuild and a lot of other things. Sorry about that!

@dbreese
Copy link
Collaborator

dbreese commented Jun 30, 2023

Probably want to update the RELEASE.md to remove the section you added about the pruning as well.

@khawkins
Copy link
Collaborator Author

Probably want to update the RELEASE.md to remove the section you added about the pruning as well.

Yep I'll update that over here. Good catch!

@khawkins
Copy link
Collaborator Author

Yip, you are correct, sir! Not sure what else I was seeing, but maybe it was a combination of trying the -external:* parms on esbuild and a lot of other things. Sorry about that!

Oh no worries, there are a lot of moving parts in the bundling and packaging. It's taken some time for me to even get my head 75% of the way around it. The remaining 25% is still 🫤.

@khawkins khawkins merged commit db0c333 into salesforce:main Jun 30, 2023
@khawkins khawkins deleted the remove_remove branch June 30, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants