L10n of all strings. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khawkins
reviewed
Jun 13, 2023
src/commands/authorizeCommand.ts
Outdated
| import { OrgUtils } from '../utils/orgUtils'; | ||
|
|
||
| export class AuthorizeCommand { | ||
| static async authorizeToOrg(): Promise<boolean> { | ||
| const user = await OrgUtils.getDefaultUser(); | ||
| let userAuthorized = false; | ||
| await OrgUtils.getDefaultUser() |
There was a problem hiding this comment.
This is a strange mix of await and then(). Why are we mixing these two competing design patterns?
There was a problem hiding this comment.
Maybe I am not fully understanding the Promise() behavior then. Seems there are two patterns I can use:
try {
await somePromise()
} catch {
// it was rejected or some error occurred
}
or just chain them with the .then() and .catch()?
There was a problem hiding this comment.
Yes, that's correct. Whereas here we're doing await / then(), which is mixing sync and async Promise consumption. We should do one or the other.
khawkins
reviewed
Jun 13, 2023
khawkins
requested changes
Jun 13, 2023
khawkins
approved these changes
Jun 13, 2023
sfdctaka
reviewed
Jun 13, 2023
Comment on lines
+13
to
22
| try { | ||
| await OrgUtils.getDefaultUser(); | ||
| return Promise.resolve(true); | ||
| } catch { | ||
| // Ask user to authorize to an org now only if not authorized yet. | ||
| const result = await window.showInformationMessage( | ||
| 'Do you want to authorize an Org now?', | ||
| { title: 'Authorize' }, | ||
| { title: 'No' } | ||
| l10n.t('Do you want to authorize an Org now?'), | ||
| { title: l10n.t('Authorize') }, | ||
| { title: l10n.t('No') } | ||
| ); |
Ran prettier, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored OrgUtils to use a reject() when username is not determined.
Also fixed simple lint warnings.
@khawkins @sfdctaka @maliroteh-sf