Changing it so that a single sobject error (ie, Visit) doesnt fail al…

…l generation.
salesforce · Nov 15, 2023 · 2823dad · 2823dad
1 parent 7f16b94
commit 2823dad
Showing 1 changed file with 38 additions and 32 deletions.
diff --git a/src/commands/wizard/lwcGenerationCommand.ts b/src/commands/wizard/lwcGenerationCommand.ts
@@ -56,16 +56,15 @@ export class LwcGenerationCommand {
                             const quickActionStatus =
                                 await LwcGenerationCommand.checkForExistingQuickActions();
 
-                            await LwcGenerationCommand.generateMissingLwcsAndQuickActions(
-                                extensionUri,
-                                quickActionStatus
-                            );
+                            const newLwcQuickActionStatus =
+                                await LwcGenerationCommand.generateMissingLwcsAndQuickActions(
+                                    extensionUri,
+                                    quickActionStatus
+                                );
 
                             // send back updates so UI can be refreshed
                             if (callback) {
-                                const quickActionStatus =
-                                    await LwcGenerationCommand.checkForExistingQuickActions();
-                                callback(quickActionStatus);
+                                callback(newLwcQuickActionStatus);
                             }
                         }
                     },
@@ -158,36 +157,43 @@ export class LwcGenerationCommand {
     ): Promise<SObjectQuickActionStatus> {
         return new Promise<SObjectQuickActionStatus>(async (resolve) => {
             for (const sobject in quickActionStatus.sobjects) {
-                const quickActions = quickActionStatus.sobjects[sobject];
-
-                if (
-                    !quickActions.create ||
-                    !quickActions.edit ||
-                    !quickActions.view
-                ) {
-                    // at least 1 needs to be created
-                    const compactLayoutFields =
-                        await OrgUtils.getCompactLayoutFieldsForSObject(
-                            sobject
-                        );
+                try {
+                    const quickActions = quickActionStatus.sobjects[sobject];
+
+                    if (
+                        !quickActions.create ||
+                        !quickActions.edit ||
+                        !quickActions.view
+                    ) {
+                        // at least 1 needs to be created
+                        const compactLayoutFields =
+                            await OrgUtils.getCompactLayoutFieldsForSObject(
+                                sobject
+                            );
 
-                    const codeBuilder = new CodeBuilder(
-                        extensionUri,
-                        sobject,
-                        compactLayoutFields
-                    );
+                        const codeBuilder = new CodeBuilder(
+                            extensionUri,
+                            sobject,
+                            compactLayoutFields
+                        );
 
-                    if (!quickActions.view) {
-                        await codeBuilder.generateView();
-                    }
+                        if (!quickActions.view) {
+                            await codeBuilder.generateView();
+                        }
 
-                    if (!quickActions.edit) {
-                        await codeBuilder.generateEdit();
-                    }
+                        if (!quickActions.edit) {
+                            await codeBuilder.generateEdit();
+                        }
 
-                    if (!quickActions.create) {
-                        await codeBuilder.generateCreate();
+                        if (!quickActions.create) {
+                            await codeBuilder.generateCreate();
+                        }
                     }
+                } catch (err) {
+                    console.error(
+                        `Could not generate quick actions for sobject ${sobject}, so skipping`,
+                        err
+                    );
                 }
             }