-
Couldn't load subscription status.
- Fork 423
feat(compiler): script transformer experimentalErrorRecoveryMode #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rax-it
wants to merge
10
commits into
master
Choose a base branch
from
rave/lwc-errors-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+958
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
reviewed
Oct 23, 2025
|
|
||
| expect(() => { | ||
| transformSync(actual, 'foo.js', TRANSFORM_OPTIONS); | ||
| }).toThrowAggregateError(['LWC1107: Invalid property name "dataInvalidProperty".']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| }).toThrowAggregateError(['LWC1107: Invalid property name "dataInvalidProperty".']); | |
| }).toThrow(aggregatErrorMatcher(['LWC1107: Invalid property name "dataInvalidProperty".'])); |
We can use asymmetric matchers to avoid having to a whole new thing.
function aggregateErrorMatcher(messages: string[]) {
return expect.objectContaining({
name: 'AggregateError',
message: 'Multiple errors occurred during compilation.',
errors: messages.map((msg) => {
return expect.objectContaining({
name: 'Error',
message: expect.stringContaining(msg),
});
}),
});
}
packages/@lwc/babel-plugin-component/src/__tests__/index.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This change introduces a
transformOption:experimentalErrorRecoveryModewhich also sets babel parsers errorRecovery flag.This changes lwc compilers, specifically
babel-plugin-componentbehavior fromWhile in theory we might still get errors in subsequent compile requests as some validation paths were skipped because we couldn't continue in a meaningful way.
These errors are then put in-to a bag of errors,
{metadata: { lwcErrors: CompilerError[]}}, upon completion of the transform process our transformer looks for presence of these errors and throws anAggregateError.Currently, only scriptTransformer is updated to utilize this behavior with other transformers (html, css) to follow suit.
experimentalErrorRecoveryModedefaults to false hence there should be no observable changes in current compilation scenarios.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-19992686