Update to golang 1.21.1 #16
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
go.mod
Outdated
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.21.1 |
There was a problem hiding this comment.
what's the motivation behind pinning a toolchain? do we need this, or do we at least want to allow upgrades?
There was a problem hiding this comment.
i c&p'd without understanding... I'll remove this and read the docs https://go.dev/doc/toolchain
Makefile
Outdated
| lint: bin/golangci-lint-1.47.2 | ||
| ./bin/golangci-lint-1.47.2 run ./... | ||
| lint: bin/golangci-lint-1.54.2 | ||
| ./bin/golangci-lint-1.54.2 run ./... |
There was a problem hiding this comment.
there is also an action for this https://github.com/golangci/golangci-lint-action
Why/What
Keeping up with the jonses. Update this to use golang 1.21.