Lint rule offline supported scope #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifeng-li-at-salesforce
requested review from
khawkins,
sfdctaka,
maliroteh-sf and
ben-zhang-at-salesforce
as code owners
sfdctaka
reviewed
May 20, 2024
sfdctaka
reviewed
May 22, 2024
sfdctaka
reviewed
May 22, 2024
sfdctaka
reviewed
May 22, 2024
sfdctaka
force-pushed
the
lintRuleOfflineSupportedScope
branch
from
cbac675
to
5536e9a
Compare
sfdctaka
reviewed
May 23, 2024
sfdctaka
reviewed
May 23, 2024
ben-zhang-at-salesforce
approved these changes
May 23, 2024
sfdctaka
reviewed
May 23, 2024
| type: 'problem', | ||
| docs: { | ||
| category: 'Operations', | ||
| description: `For mobile offline use cases, scope "MINE" is supported and scope "ASSIGNEDTOME" is only supported for ServiceAppointment . All other scopes like TEAM, QUEUE_OWNED and USER_OWNED are not supported `, |
There was a problem hiding this comment.
Suggested change
| description: `For mobile offline use cases, scope "MINE" is supported and scope "ASSIGNEDTOME" is only supported for ServiceAppointment . All other scopes like TEAM, QUEUE_OWNED and USER_OWNED are not supported `, | |
| description: `For mobile offline use cases, scope "MINE" is supported and scope "ASSIGNEDTOME" is only supported for ServiceAppointment. All other scopes like TEAM, QUEUE_OWNED and USER_OWNED are not supported.`, |
sfdctaka
reviewed
May 23, 2024
| }, | ||
| messages: { | ||
| [SCOPE_SUPPORTED_FOR_CERTAIN_ENTITIES_ONLY]: | ||
| 'Offline GraphQL: Scope "{{scopeName}}" is only supported for the "{{supportedEntities}}" entity, for mobile offline use cases', |
There was a problem hiding this comment.
Suggested change
| 'Offline GraphQL: Scope "{{scopeName}}" is only supported for the "{{supportedEntities}}" entity, for mobile offline use cases', | |
| 'Offline GraphQL: Scope "{{scopeName}}" is only supported for the "{{supportedEntities}}" entity, for mobile offline use cases.', |
sfdctaka
approved these changes
May 23, 2024
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-15792451
per Feature Limitations of Offline Graphql, graphql local eval doesn't support TEAM, QUEUEOWNED, USEROWNED, EVERYTHING yet, ASSIGNEDTOME is not supported except for ServiceAppointment. so need eslint rule to warn lwc developer if the crafted graphql statement has such scope filter.