Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint rule mutation not supported #6

Merged
merged 5 commits into from
May 21, 2024

Conversation

haifeng-li-at-salesforce
Copy link
Collaborator

W-15782130

graphql local eval doesn't support graphql mutation yet. This eslint rule warns lwc developer if the crafted graphql statement has mutation operation.

The below is the screenshot from offline-app-developer-starter-kit which installs our plugin.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types provides additional information for TypeScript compiler. Especially GraphQLESTreeNode allows developers to take advantage of ESLintTreeNode

Copy link
Collaborator

@ben-zhang-at-salesforce ben-zhang-at-salesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost peer coded , looks good to me

docs: {
description: 'mutation is not supported offline',
category: 'Operations',
recommended: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url will be added once Takashi's apex pr is merged, will use uplift his url generation logic to be used by all rules.

package.json Outdated Show resolved Hide resolved
src/configs/base.ts Outdated Show resolved Hide resolved
src/rules/utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@khawkins khawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty good to me! Just some minor comments.

Copy link
Collaborator

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haifeng-li-at-salesforce haifeng-li-at-salesforce merged commit 8c1607b into main May 21, 2024
17 checks passed
@sfdctaka sfdctaka deleted the lintRuleMutationNotSupported branch May 21, 2024 18:04
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 10, 2024
@salesforce salesforce deleted a comment from github-actions bot Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants