use Typescript instead of JS to improve dev productivity

[ben-zhang-at-salesforce]

• bring in typescript setup for code and jest test.
• convert the dummy first rule and test to typescript

[khawkins]

I'm going to suggest a package structure change too: move all of the source files under src/, and reserve lib/ for the built package JS artifacts. This is a more standard layout for TypeScript projects.

[khawkins]

I'm going to suggest a package structure change too: move all of the source files under src/, and reserve lib/ for the built package JS artifacts. This is a more standard layout for TypeScript projects.

I see that we specify dist/ as the output dir in tsconfig.json, which is fine too. But I think our TS source files should go under src/.

[khawkins]

I think that's all I had!

[ben-zhang-at-salesforce]

I think that's all I had!

thanks for review it, learned a lot :)

[khawkins]

I think it doesn't matter in this moment because this repo will get flattened before we flip it to public, but: you need to have your GitHub commit signing configuration applied to this repo, so that your commits are signed. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[ben-zhang-at-salesforce]

I think it doesn't matter in this moment because this repo will get flattened before we flip it to public, but: you need to have your GitHub commit signing configuration applied to this repo, so that your commits are signed. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

sure, I will put it on my plate once we has 1 or two mature apex and graphql rule coded.

[khawkins]

Sorry, my point with tsconfig.tsbuildinfo was to put it in .gitignore. It's just a build artifact that can be ignored. It should not be committed to the project.

[khawkins]

I think this looks good as our first pass. We'll probably encounter configuration tweaks as we go, but this looks good to me.