fix: remove source code for GraphQLESTreeNode #17
Conversation
haifeng-li-at-salesforce
requested review from
khawkins,
sfdctaka,
maliroteh-sf and
ben-zhang-at-salesforce
as code owners
haifeng-li-at-salesforce
changed the title
| "paths": { | ||
| /* TS complains not about to infer GraphQLESTreeNode */ | ||
| "@graphql-eslint/eslint-plugin/estree-converter/*": [ | ||
| "./node_modules/@graphql-eslint/eslint-plugin/cjs/estree-converter/*" |
There was a problem hiding this comment.
I like to point it out that using 'esm' instead of 'cjs' would not work. It would complain 'Could not find a declaration file'
There was a problem hiding this comment.
look around bit more, lwc_mobile's "type" is "commonjs". graphql-eslint package.json has below.
"main": "cjs/index.js", // for common.js
"module": "esm/index.js",// for esm.
commonjs consumer looks for commonjs dependency.
There was a problem hiding this comment.
Yeah, that was my intuition too. But this is a great start! I going to poke around a bit on my own with regards to our overall project configuration. I wish it wasn't quite so tenuous to configure TypeScript projects. 🙄
There was a problem hiding this comment.
I.e. I'm not sure if we need to be a "commonjs" type of project, vs. reconfiguring our transpilation and/or packaging. If I look at ten different projects, I see ten different approaches to project configurations for issues like these. I imagine someday I'm going to have to work myself from the ground floor of the ECMAScript and modules spec, up through TypeScript specs and consumption, to module bundlers, to fully grasp how this is all supposed to work. 😭
Remove the source code file 'GraphQLESTreeNode'