Unified message ID in all caps following no mutation supported rule.

salesforce · May 21, 2024 · 173e70e · 173e70e
1 parent 10e3218
commit 173e70e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -8,7 +8,7 @@
 import base from './configs/base.js';
 import recommended from './configs/recommended.js';
 import enforceFooBar from './rules/dummy/enforce-foo-bar.js';
-import apexImport from './rules/apex/apex-import.js';
+import { rule as apexImport, APEX_IMPORT_RULE_ID } from './rules/apex/apex-import.js';
 import {
     rule as mutionNotSupported,
     NO_MUTATION_SUPPORTED_RULE_ID
@@ -26,6 +26,6 @@ export = {
     rules: {
         'enforce-foo-bar': enforceFooBar,
         [NO_MUTATION_SUPPORTED_RULE_ID]: mutionNotSupported,
-        'apex-import': apexImport
+        [APEX_IMPORT_RULE_ID]: apexImport
     }
 };
diff --git a/src/rules/apex/apex-import.ts b/src/rules/apex/apex-import.ts
@@ -6,15 +6,16 @@
  */
 
 import createRule from '../../util/createRule';
+export const APEX_IMPORT_RULE_ID = 'apex-import';
 
-export default createRule({
+export const rule = createRule({
     create(context) {
         return {
             ImportDeclaration(node) {
                 if (node.source.value.startsWith('@salesforce/apex')) {
                     context.report({
                         node,
-                        messageId: 'message'
+                        messageId: APEX_IMPORT_RULE_ID
                     });
                 }
             }
@@ -26,7 +27,8 @@ export default createRule({
             description: 'Importing apex modules can have issues on mobile for offline usage.'
         },
         messages: {
-            message: 'Importing apex modules can have issues on mobile for offline usage.'
+            [APEX_IMPORT_RULE_ID]:
+                'Importing apex modules can have issues on mobile for offline usage.'
         },
         type: 'suggestion',
         schema: []

diff --git a/test/rules/apex/apex-import.ts b/test/rules/apex/apex-import.ts
@@ -7,13 +7,13 @@
 
 import { RuleTester } from '@typescript-eslint/rule-tester';
 
-import apexImport from '../../../src/rules/apex/apex-import';
+import { rule, APEX_IMPORT_RULE_ID } from '../../../src/rules/apex/apex-import';
 
 const ruleTester = new RuleTester({
     parser: '@typescript-eslint/parser'
 });
 
-ruleTester.run('@salesforce/lwc-mobile/apex/apex-import', apexImport, {
+ruleTester.run('@salesforce/lwc-mobile/apex/apex-import', rule, {
     valid: [
         {
             code: `
@@ -60,7 +60,7 @@ ruleTester.run('@salesforce/lwc-mobile/apex/apex-import', apexImport, {
                 }
             }
             `,
-            errors: [{ messageId: 'message' }]
+            errors: [{ messageId: APEX_IMPORT_RULE_ID }]
         }
     ]
 });