Fix internal jenkins job to create RPM #697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzxu-crm
reviewed
Aug 4, 2023
| @@ -9,6 +9,10 @@ FROM quay.io/centos/centos:stream8 | |||
| ARG DEPENDENCY=build/docker/dependency | |||
| ARG VERSION=latest | |||
|
|
|||
| RUN cd /etc/yum.repos.d/ | |||
| RUN sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* | |||
| RUN sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* | |||
There was a problem hiding this comment.
While you are touching this file, can you please consolidate all RUN into a single command? Each RUN produce a layer on the image which is insane.
There was a problem hiding this comment.
This actually doesn't work because the base is centos8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.