refactoring php v2 adam #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Purchase of {amount} with {card} at {brand},', | ||
| 'Payment of {amount} to {brand} with {card}.', | ||
| ]; | ||
| private $keywords = ['amount', 'brand', 'card', 'account', 'datetime']; |
There was a problem hiding this comment.
do we need this array? can we simply replace anything with the {} with "(.*?)"
|
|
||
| class SmsTemplateDetector | ||
| { | ||
| private $templates = [ |
There was a problem hiding this comment.
good move. however, do you think this data should be in this class?
| foreach($this->templates as $template) { | ||
| $re_pattern = $this->getRePattern($template); | ||
|
|
||
| if(preg_match($re_pattern, $sms, $matched_parts)) { |
There was a problem hiding this comment.
can we simplify this condition as a method to make it more readable?
| test('it returns correct matched template with extracted data', function () { | ||
| $sut = new SmsTemplateDetector; | ||
|
|
||
| $smsTemplate = $sut->detect("Payment of 33.3 to Apple with 4233."); |
There was a problem hiding this comment.
can we add the missing tests and convert this into dataset testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what do you think ?