fix: Return 404 if a custom script or style is not found #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move abort inline with previous code Fix test names
wsamoht
force-pushed
the
fix-scripts-styles-not-found
branch
from
ba64bad to
8d0a573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My site has gotten hit by a malicious actor several times hitting the routes to load the custom scripts or styles with non-existent scripts/styles.
An example being
/docs/scripts/non-existent-504843668(with the number being different each time) and/docs/styles/non-existent-945848484.When this happens, we get a ton of errors because when these non-existent scripts/styles try to get loaded, a 500 is thrown with the error
Undefined array key "non-existent-504843668".I have fixed this so instead of a 500 being thrown, a 404 is returned.