-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Categorization, Rate Limiting, and Feature Flags #177
Conversation
f16010c
to
5a81371
Compare
This looks amazing. I will take a closer look and test it in following days. |
Thank you! Let me know what you'd need. Also you can get a valueserp API key with about 1000 requests for free so you can test |
What do you think @sakowicz ? Needs more work? I put most work behind feature flags and most setups should not be affected |
I'm sorry this is taking so long. The PR is really big and I've never had a chance to to test it yet. However:
Thank you for the contribution. I'm going to test it soon. I'm doing this CR from my phone 🙈 |
Those are valid points and I will be fixing them soon. I will look into implementing bing/duckduckgo For the credit card, that's a mistake from my own rules bleeding into my pr. It's quite large and I kept needing this and that until everything depended on everything else so I pushed it here as a self contained featureset |
… and add tests for search functionality.
…clarify features. Refactor ActualAiService to use feature flag for syncAccountsBeforeClassify.
I've made the changes and update, for search we will be using Duck Duck Go's public search, it's surprisingly good. It will be enabled through the freeWebSearch, updated the features except for dry_run. Finally, removed the credit card rule I had accidentally added. |
Thank you for the contribution. And sorry that it took so long. |
FYI: I've split the transaction-service into the multiple files bdc9ad1 If you've time it would be nice to unit test Transaction-service becomes huge and we'd have to refactor it if we want to maintain this project. |
Key Changes
Testing
Configuration
All features configurable via environment variables as documented in README.md. Maintains backward compatibility while adding new capabilities.