SAK-47102 Samigo display pool owner name to help identify pool ownership #13395
+81
−360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusmmp
reviewed
Mar 5, 2025
...migo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/SectionContentsBean.java
Outdated
Show resolved
Hide resolved
jesusmmp
reviewed
Mar 5, 2025
| @@ -340,6 +342,8 @@ $(window).load( function() { | |||
| <f:param value="#{partBean.poolNameToBeDrawn}"/> | |||
| <f:param value="#{partBean.randomQuestionsDrawDate}"/> | |||
| <f:param value="#{partBean.randomQuestionsDrawTime}"/> | |||
| <f:param value="#{partBean.poolOwnerDisplay}"/> | |||
| <f:param value="#{partBean.poolOwnerDisplay}"/> | |||
jesusmmp
reviewed
Mar 5, 2025
| @@ -349,6 +353,8 @@ $(window).load( function() { | |||
| <f:param value="#{partBean.poolNameToBeDrawn}"/> | |||
| <f:param value="#{partBean.randomQuestionsDrawDate}"/> | |||
| <f:param value="#{partBean.randomQuestionsDrawTime}"/> | |||
| <f:param value="#{partBean.poolOwnerDisplay}"/> | |||
| <f:param value="#{partBean.poolOwnerDisplay}"/> | |||
There was a problem hiding this comment.
i believe it is purposeful .... i can take another look but i think it's needed twice
jesusmmp
reviewed
Mar 5, 2025
| @@ -543,13 +434,27 @@ public void setMetadataRandowDraw(SectionDataIfc section) { | |||
| setRandomQuestionsDrawTime(drawTimeString); | |||
|
|
|||
| } catch(Exception e){ | |||
| log.error("Unable to parse date text: " + randomDrawDate, e); | |||
| log.error("Unable to parse date text: {}", randomDrawDate, e); | |||
…/bean/delivery/SectionContentsBean.java Co-authored-by: Jesús María Méndez Pérez <[email protected]>
jesusmmp
reviewed
Mar 5, 2025
| @@ -520,7 +411,7 @@ public void setMetadataRandowDraw(SectionDataIfc section) { | |||
| String poolname = section.getSectionMetaDataByLabel(SectionDataIfc.POOLNAME_FOR_RANDOM_DRAW); | |||
| if (SectionDataIfc.RANDOM_DRAW_FROM_QUESTIONPOOLS.equals(Integer.valueOf(section.getSectionMetaDataByLabel(SectionDataIfc.AUTHOR_TYPE))) && | |||
| section.getSectionMetaDataByLabel(SectionDataIfc.RANDOM_POOL_COUNT) != null) { | |||
| Integer count = Integer.valueOf(section.getSectionMetaDataByLabel(SectionDataIfc.RANDOM_POOL_COUNT)); | |||
There was a problem hiding this comment.
There are more Integer.valueOf on this file... e.x
https://github.com/sakaiproject/sakai/pull/13395/files#diff-427b06a8f86a14d72b1c42d4ee13021b6e85bcff920cc427ee67bec0548e6a12R400
There was a problem hiding this comment.
ok all the available ones are done.
jesusmmp
reviewed
Mar 5, 2025
...migo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/SectionContentsBean.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.