Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRSTR-368 - Updates to the docker directory #13113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonespm
Copy link
Contributor

@jonespm jonespm commented Dec 16, 2024

Removed old config that waasn't likely used
Put the Dockerfile at the top level with an updated readme Tested that this mimially works with the current version of Sakai

TODO ideas in a future fix:

  • Use docker-compose.yml on the top level to make starting this up easier This would also allow for a persistent volume for MySQL

  • Split tomcat from the Dockerfile and have it run separately.

  • Verify if we still need the docker-maven-chrome or if we can use the regular maven to build

  • Create a .dockerignore (if needed)

  • Build from this directory instead of checking out again. I skipped this for now because it would have to clean up before building

  • Verify and perform additional cleanup on the container (if possible)

Removed old config that waasn't likely used
Put the Dockerfile at the top level with an updated readme
Tested that this mimially works with the current version of Sakai

TODO ideas in a future fix:

* Use docker-compose.yml on the top level to make starting this up easier
This would also allow for a persistent volume for MySQL

* Split tomcat from the Dockerfile and have it run separately.

* Verify if we still need the docker-maven-chrome or if we can use the regular maven to build
@jonespm jonespm requested review from ern and csev December 16, 2024 01:05
@jonespm
Copy link
Contributor Author

jonespm commented Dec 16, 2024

@ern @csev

I validated that this runs and starts up locally. It cleans up a lot in the docker directory that was outdated while providing a file and working route to build and run from source in Sakai 17.

There's additional work here if people use this but this feels like a minimum viable product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant