SAK-50756 Tags new endpoint to get assignments #13107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgarciaentornos
changed the title
ern
changed the title
ern
requested changes
Dec 12, 2024
| private SessionManager sessionManager = (SessionManager) ComponentManager.get("org.sakaiproject.tool.api.SessionManager"); | ||
| private SessionManager sessionManager = (SessionManager) ComponentManager.get("org.sakaiproject.tool.api.SessionManager"); | ||
|
|
||
| private AssignmentService assignmentService = (AssignmentService) ComponentManager.get("org.sakaiproject.assignment.api.AssignmentService");; |
There was a problem hiding this comment.
It propbably makes sense to use the entity manager vs the assignment service directly as your only retrieving assignments.
Also it would be ideal to migrate away from using the ComponentManager directly
There was a problem hiding this comment.
I changed the approach deleting the use of assignment service, the endpoint could be used for other tools.
bgarciaentornos
requested changes
Dec 13, 2024
| String assignmentId = wp.getString("assignmentId"); | ||
|
|
||
| Assignment assignment = assignmentService.getAssignment(assignmentId); | ||
| String siteId = assignment.getContext(); |
There was a problem hiding this comment.
SiteId should be a param , this can be called from other tools too. Method should be renamed too
jumarub
force-pushed
the
SAK-50756
branch
2 times, most recently
from
e5ee466 to
49096d1
Compare
bgarciaentornos
approved these changes
Dec 13, 2024
ern
reviewed
Dec 13, 2024
Comment on lines
+220
to
+229
| try { | ||
| WrappedParams wp = new WrappedParams(params); | ||
| String itemId = wp.getString("itemId"); | ||
| String siteId = wp.getString("siteId"); | ||
|
|
||
| List<Tag> tagList = tagService().getAssociatedTagsForItem(siteId, itemId); | ||
|
|
||
| return buildtagJsonOject(tagList, tagList.size()); | ||
| } catch (Exception e) { | ||
| log.error("Error calling getTagsByItemId:", e); |
There was a problem hiding this comment.
Suggested change
| try { | |
| WrappedParams wp = new WrappedParams(params); | |
| String itemId = wp.getString("itemId"); | |
| String siteId = wp.getString("siteId"); | |
| List<Tag> tagList = tagService().getAssociatedTagsForItem(siteId, itemId); | |
| return buildtagJsonOject(tagList, tagList.size()); | |
| } catch (Exception e) { | |
| log.error("Error calling getTagsByItemId:", e); | |
| WrappedParams wp = new WrappedParams(params); | |
| String itemId = wp.getString("itemId"); | |
| String siteId = wp.getString("siteId"); | |
| try { | |
| List<Tag> tagList = tagService().getAssociatedTagsForItem(siteId, itemId); | |
| return buildtagJsonOject(tagList, tagList.size()); | |
| } catch (Exception e) { | |
| log.warn("Could not get tag with itemId={} in site={}, {}", itemId, siteId, e); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50756