SAK-50631 Samigo SEB autosave modal message is sometimes permanently displayed #13058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's important to highlight we discovered it with the SEB integration but this might happen in other timed situations, the problem is in the autosave function and the fix is applied to allow Samigo to recover when losing the correct time values. |
ern
changed the title
ern
reviewed
Nov 26, 2024
samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
Outdated
Show resolved
Hide resolved
stetsche
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50631
We have identified some rare cases where the frontend loses the values of timeLimit and timeElapse (resetting them to 0). This leads to the frontend triggering the final submission of the assessment, rendering it inaccessible to the student, which is unacceptable during an assessment. This solution aims to prevent these errors. When the frontend encounters a timeLimit value of 0 (which is not possible in a timed assessment) it should use timeLimit_bck and timeElapse_bck instead.