Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49440 msgcntr modify the default behavior for 'mark as read' #12948

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jesusmmp
Copy link
Contributor

@jesusmmp jesusmmp commented Oct 7, 2024

ern
ern previously approved these changes Oct 14, 2024
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just needs a couple of minor changes, so I will approve

messageManager.markMessageNotReadForUser(selectedTopic.getTopic().getId(), ((DiscussionMessageBean)selectedThread.get(i)).getMessage().getId(), readStatus); //true
((DiscussionMessageBean)selectedThread.get(i)).setRead(Boolean.FALSE);
}
//}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Comment on lines +2747 to +2750
// now process the complete list of messages in the selected thread to possibly flag as read
// if this topic is flagged to autoMarkThreadsRead, mark each message in the thread as read
// mark all as not read
//if (selectedTopic.getTopic().getAutoMarkThreadsRead()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up this comment

nr = Integer.valueOf(nr.intValue() - 1);
}
message.setNumReaders(nr);
log.debug("set Message readers count to: " + nr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.debug("set Message readers count to: " + nr);
log.debug("set message readers count to [{}]", nr);

return THREAD_VIEW;
}

public String processActionGetDisplayThread(boolean readStatus)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing in this method is off

@ern ern changed the title SAK-49440 Modify the default behaviour of the 'mark as read' in the forums tool. SAK-49440 msgcntr modify the default behavior for 'mark as read' Oct 14, 2024
@jesusmmp
Copy link
Contributor Author

Looks good just needs a couple of minor changes, so I will approve

There is still a lot of work to be done here

@ern ern dismissed their stale review October 14, 2024 16:16

more work to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants