-
-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-49440 msgcntr modify the default behavior for 'mark as read' #12948
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just needs a couple of minor changes, so I will approve
messageManager.markMessageNotReadForUser(selectedTopic.getTopic().getId(), ((DiscussionMessageBean)selectedThread.get(i)).getMessage().getId(), readStatus); //true | ||
((DiscussionMessageBean)selectedThread.get(i)).setRead(Boolean.FALSE); | ||
} | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
// now process the complete list of messages in the selected thread to possibly flag as read | ||
// if this topic is flagged to autoMarkThreadsRead, mark each message in the thread as read | ||
// mark all as not read | ||
//if (selectedTopic.getTopic().getAutoMarkThreadsRead()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up this comment
nr = Integer.valueOf(nr.intValue() - 1); | ||
} | ||
message.setNumReaders(nr); | ||
log.debug("set Message readers count to: " + nr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.debug("set Message readers count to: " + nr); | |
log.debug("set message readers count to [{}]", nr); |
return THREAD_VIEW; | ||
} | ||
|
||
public String processActionGetDisplayThread(boolean readStatus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing in this method is off
There is still a lot of work to be done here |
https://sakaiproject.atlassian.net/browse/SAK-49440