Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix copy-mode and keybindings with brackets #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix copy-mode and keybindings with brackets #66

wants to merge 2 commits into from

Conversation

iloveitaly
Copy link
Contributor

  • fix copy-mode removal when not in copy mode
  • fix: keybinding bracket commands

@iloveitaly
fix copy-mode removal when not in copy mode
4fa028a
@iloveitaly
fix: keybinding bracket commands
d16de40 
A keybinding like this:

```
command-prompt -T window-target -p index { select-window -t ":%%" }'
```

does not execute without this awk command

Also, the `sed` replacement fixed menu corruption for me.
@iloveitaly
Copy link
Contributor Author

@sainnhe friendly reminder here!

@isidroas
Copy link
Contributor

  • fix copy-mode removal when not in copy mode

I also found this issue. Another way to fix is here #82

sainnhe
sainnhe requested changes Apr 1, 2024
View reviewed changes
Copy link
Owner

@sainnhe sainnhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not replying for so long... I'm just so stupid because I reviewed your PR a long time ago but I forgot to submit it, so the review is in pending state and you can't see it. I'm really sorry for this :(

截屏2024-04-01 21 42 45

main.sh
@@ -6,7 +6,7 @@ source "$CURRENT_DIR/scripts/.envs"

# remove copy-mode from options if we aren't in copy-mode
if [[ "$TMUX_FZF_ORDER" == *"copy-mode"* ]] && [ "$(tmux display-message -p '#{pane_in_mode}')" -eq 0 ]; then
TMUX_FZF_ORDER="$(echo $TMUX_FZF_ORDER | sed -E 's/\|?copy-mode\|?//')"
TMUX_FZF_ORDER="$(echo $TMUX_FZF_ORDER | sed -E 's/\|?copy-mode\|?/|/')"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this? I intentionally removed | because this will make the first line become empty.

@isidroas isidroas mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainnhe sainnhe sainnhe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iloveitaly @isidroas @sainnhe