Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package systemd unit files #2

Closed
wants to merge 6 commits into from
Closed

package systemd unit files #2

wants to merge 6 commits into from

Conversation

Olf0
Copy link

@Olf0 Olf0 commented Aug 29, 2021

@Olf0
Copy link
Author

Olf0 commented Aug 29, 2021

P.S.: For reference and testing also see https://build.sailfishos.org/package/show/home:nephros/util-linux
but the latest build there includes an additional commit (to enable easy testing): https://gitlab.com/nephros/sailfishos-util-linux/-/compare/master...c9a77120?from_project_id=28856859

Tone down dependencies for the systemd units
...so they can be installed independently of main package version.
Intended for testing.
As newer versions in upstream use different options to the utility this should not be done in any release version of this package, as it may break in a future version.

rpm/util-linux.spec Outdated Show resolved Hide resolved
... at the start of this spec file, instead of two sub-package specific statements, as requested by @okodron.
Also use BuildRequires: pkgconfig(systemd) instead of BuildRequires: systemd-devel
@Olf0 Olf0 requested a review from Thaodan August 30, 2021 20:21
rpm/util-linux.spec Outdated Show resolved Hide resolved
rpm/util-linux.spec Outdated Show resolved Hide resolved
... as requested by @okodron:
"Description should end with full stop to make rpmlint happy:"

Co-authored-by: Andrey Okoshkin <[email protected]>
rpm/util-linux.spec Outdated Show resolved Hide resolved
... as requested by @okodron: "Description should end with full stop to make rpmlint happy."
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please smash your fixup commit together with the original commit and don't add groups.
See the links below for more information:
https://sailfishos.org/wiki/Software_Packaging
https://sailfishos.org/wiki/Collaborative_Development

As a community contributor, Jolla's non-public style-guides and its changes ("we don't use this >anymore") are unknown to me.

Jolla's guidelines on this are public as shown above ;)
Please look into them and come back to me if something is missing on our side.

... for the newly added sub-packages (in contrast to all extant sub.packages), as requested by @Thaodan.
@Olf0 Olf0 mentioned this pull request Aug 31, 2021
@Olf0
Copy link
Author

Olf0 commented Aug 31, 2021

Please smash your fixup commit together with the original commit and don't add groups.

Oh my ...; well, see PR #3.

@Olf0 Olf0 closed this Aug 31, 2021
@Thaodan
Copy link
Contributor

Thaodan commented Aug 31, 2021

Please smash your fixup commit together with the original commit and don't add groups.

Oh my ...; well, see PR #3.

For the future please look into this about rebasing and squashing commits:
https://git-scm.com/docs/git-rebase#_interactive_mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants