-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package systemd unit files #2
Conversation
- enable systemd in configure - package fstrim.timer - package uuidd.service as per https://gitlab.com/nephros/sailfishos-util-linux/-/compare/master...50a6d02b?from_project_id=28856859 Background information: https://forum.sailfishos.org/t/feature-suggestion-install-and-use-systemds-fstrim-timer/7634
P.S.: For reference and testing also see https://build.sailfishos.org/package/show/home:nephros/util-linux
|
... at the start of this spec file, instead of two sub-package specific statements, as requested by @okodron. Also use BuildRequires: pkgconfig(systemd) instead of BuildRequires: systemd-devel
... as requested by @okodron: "Description should end with full stop to make rpmlint happy:" Co-authored-by: Andrey Okoshkin <[email protected]>
... as requested by @okodron: "Description should end with full stop to make rpmlint happy."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please smash your fixup commit together with the original commit and don't add groups.
See the links below for more information:
https://sailfishos.org/wiki/Software_Packaging
https://sailfishos.org/wiki/Collaborative_Development
As a community contributor, Jolla's non-public style-guides and its changes ("we don't use this >anymore") are unknown to me.
Jolla's guidelines on this are public as shown above ;)
Please look into them and come back to me if something is missing on our side.
... for the newly added sub-packages (in contrast to all extant sub.packages), as requested by @Thaodan.
Oh my ...; well, see PR #3. |
For the future please look into this about rebasing and squashing commits: |
as per https://gitlab.com/nephros/sailfishos-util-linux/-/compare/master...50a6d02b?from_project_id=28856859
by @nephros
Background information: https://forum.sailfishos.org/t/feature-suggestion-install-and-use-systemds-fstrim-timer/7634
(originally at https://together.jolla.com/question/219907/please-install-and-use-systemds-fstrimtimer/)