Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various errors found during LTO build #23

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix various errors found during LTO build #23

wants to merge 9 commits into from

Commits on Mar 28, 2024

  1. [sb2] Use Version instead of non-standard V variable 

    Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c37287b View commit details
    Browse the repository at this point in the history

  2. [sb2] Correctly use $LUA_CFAGS to find lua.h 

    lua.h isn't always inside in /usr/include, take LUA_CFLAGS
as taken from pkgconfig.

Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ec1090b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. [sb2] Specify lua-posix dependency correctly for OpenSuSE 

    Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    74abd6c View commit details
    Browse the repository at this point in the history

  2. [sb2] Avoid errors in out of tree builds for files from $(OBJDIR) 

    Previously in some instance the assumption was $(SRCDIR) = $(OBJDIR).
If $(OBJDIR) isn't equal to $(SRCDIR) these files were not found anymore.

Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5d295db View commit details
    Browse the repository at this point in the history

  3. [utils] Use va_args in open_nomap_nolog to match wrappers 

    Resolves error when using a compiler with stricter settings such as
when using LTO.

Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c1b6d26 View commit details
    Browse the repository at this point in the history

  4. [preload] Adapt glibc in open ignore 'mode' with O_TMPFILE in flags 

    Both open and openat load their last argument 'mode' lazily, using
va_arg() only if O_CREAT is found in oflag. This is wrong, mode is also
necessary if O_TMPFILE is in oflag.

Adapt __OPEN_NEEDS_MODE(oflag) present since glibc 2.22 to solve the
issue.

Read more down below:
https://sourceware.org/git/?p=glibc.git;a=commit;h=65f6f938cd562a614a68e15d0581a34b177ec29d

Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0e83e30 View commit details
    Browse the repository at this point in the history

  5. [sb2] Don't run make twice 

    Once in autogen.sh and once in %make

Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    890a0e2 View commit details
    Browse the repository at this point in the history

  6. [preload] Ensure exported.h is generated first to fix parallel builds 

    Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    993dfe4 View commit details
    Browse the repository at this point in the history

  7. [llbuild] Refactor import_dir to match other Makefiles 

    Signed-off-by: Björn Bidar <[email protected]>
    @Thaodan
    Thaodan committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a4b8681 View commit details
    Browse the repository at this point in the history