Tell the observer if the download is coming from a private tab #97
Conversation
jscomps/EmbedliteDownloadManager.js
Outdated
| @@ -89,6 +91,7 @@ let DownloadView = { | |||
| JSON.stringify({ | |||
| msg: "dl-fail", | |||
| id: download.id, | |||
| privateMode: PrivateBrowsingUtils.isContentWindowPrivate(Services.ww.activeWindow) || false, | |||
There was a problem hiding this comment.
When downloading normally without pausing / cancelling and continuing download these "embed:download" notifies inside onDownloadAdded should not trigger.
In normal scenario onDownloadAdded gets called only once per download (first thing that happens). To report status changes you need to stringify download.source.isPrivate for each "embed:download" notifies of the onDownloadChanged (and onDownloadAdded). Simpler just to have it foreach "embed:download" message.
There was a problem hiding this comment.
I'm not sure I understood this, please have a look to my changes. Thanks!
|
Any comments? |
I would like to implement your changes, but had no time to work on it. Maybe next week 🤞 |
ilpianista
force-pushed
the
feature/private-mode-download
branch
from
6fb7349
to
d27bcda
Compare
ilpianista
force-pushed
the
feature/private-mode-download
branch
from
d27bcda
to
8a17fd0
Compare
Thanks, it's almost there. Easier to explain in form of PR this #98 so I created one. Point is that we need to pass privateMode update from each download message that we send from the embedlite-components to browser app. |
Follow up of sailfish-browser!1057 to propagate the private mode information.