Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Metrics #4

Merged
merged 17 commits into from
Jul 15, 2023
Merged

Crypto Metrics #4

merged 17 commits into from
Jul 15, 2023

Conversation

sahlminkok
Copy link
Owner

In this Pull Request I:

  • Make the project a single-page application (SPA) built with React and Redux.
  • The data retrieved from the API have been stored in the Redux store.
  • Filter the data retrieve from the API using a Filter stateless component.
  • Make every page (the main page and the pages for each item) with a unique route within the SPA.
  • Deployed the Project Using Render
  • Add a walk-through video to the README file
  • Create integration tests for the application using the React Testing Library.

Copy link

@AlphaNtihinduka AlphaNtihinduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hi @sahlminkok 🙋‍♂️,

Your project is complete! There is nothing else to say other than... Great job 👏

approved-accepted

Congratulations! 🎉
TO HIGHLIGHT:

  • Developed (SPA) using react-router-dom ✔️
  • Professional video presentation ✔️
  • API fetch using axios ✔️
  • Your project is professional ✔️
  • Your repo is professional ✔️
  • Well-structured files ✔️

Now you can merge this branch and move on 🥇

Optional suggestions

  • Kindly refer to the inline optional suggestions made. Ensure to apply them to have a professional project that suits recruiters' needs.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

HAPPY CODING AND GOOD LUCK WITH THE COMING ONES 🤞 🍀

@sahlminkok sahlminkok merged commit 87f3ba7 into main Jul 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants