Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1469 #1503

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix issue #1469 #1503

wants to merge 4 commits into from

Conversation

MehdioKhan
Copy link

jQuery selector to find popup content had something extra that removed. Now you can add POI from map.

@MehdioKhan
Copy link
Author

Are you (or someone you are supporting) using this application or are you just trying to help out generally?

I'm helping out generally

@flavour
Copy link
Member

flavour commented Sep 30, 2019

Are you up for trying to change the font to work via import_font to mean that we don't include it in the repo? & then do a clean rebase with single commit as a pull request?

@nursix
Copy link
Member

nursix commented Sep 30, 2019

rtl.reshaper breaks tests for Python-3 - this needs fixing before merge

@nursix
Copy link
Member

nursix commented Sep 30, 2019

Also, I'm not sure I would agree with adding the rtl library as dependency - it's unmaintained since 2016 and has no public repo. We could consider adding it to our repo, if it must, but if the BiDi variant works with the right fonts installed, then I'd prefer leaving it at that.

@nursix
Copy link
Member

nursix commented Sep 30, 2019

By contrast - the bidi library is actively maintained, and has a source repository on GitHub. So definitely preferable over rtl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants