Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup url config #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gnarula
Copy link
Contributor

@gnarula gnarula commented Feb 16, 2015

No description provided.

@nursix
Copy link
Member

nursix commented Feb 16, 2015

Config setting without use-case? I would re-submit this together with the code that uses it.

@gnarula
Copy link
Contributor Author

gnarula commented Feb 16, 2015

This was discussed in the Configuration Editor thread in the mailing list.

Added a link to the coapp in the admin menu.

@nursix
Copy link
Member

nursix commented Feb 16, 2015

I'm aware of what has been discussed - but adding a setting without also adding the use-case for it is obviously a bit pointless or at least premature.

Better now - but you should of course use the getter to retrieve the setting, not access the dict directly.

@gnarula
Copy link
Contributor Author

gnarula commented Feb 16, 2015

Sorry for that. Done now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants