[*.rs] Sort imports ; [*test*.rs] Use assert_ne! throughout
#1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagiegurari
reviewed
Jul 22, 2024
| @@ -7,15 +7,17 @@ | |||
| #[path = "diff_steps_test.rs"] | |||
| mod diff_steps_test; | |||
|
|
|||
| use std::fs::File; | |||
| use std::io; | |||
| use std::io::{BufWriter, Write}; | |||
There was a problem hiding this comment.
why is this considered sorted?
i just put everything in a pile and let the formatter do it
There was a problem hiding this comment.
stdlibraries- third-party libraries
crate(first-party) libraries
Much more readable. I think I got the idea from isort. You can configure rustfmt to do this, see https://rust-lang.github.io/rustfmt/?version=v1.7.1&search=#StdExternalCrate%5C%3A
There was a problem hiding this comment.
ya i get that but i don't want to configure anything and stay consistent with other projects out there.
when ecosystem defaults change, i'll get those and fix as needed.
the assert_ne! parts are fine so suggest to have a PR just for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.