Update lrslib to 073 with autotool patch #41047
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit dadbbc1; changes) is ready! 🎉 |
The lrslib-073 source includes an original makefile with install target that hardcodes prefix=/usr/local. This conflicts with the autotools-based build and causes files to be installed to the wrong location. Solution: Rename the original makefile to makefile.orig before running autoreconf to prevent the conflict.
- Add all 227 example/test files from games/, ext/, ine/ directories - Include new directories: ext/redund/, ext/tsp/, ine/afsa/, ine/polybase/, ine/project/, and ine/test-072/ - Update patch line count from 250 to 354 lines in Makefile.am - This ensures all test files are properly installed with the package
There was a problem hiding this comment.
Pull Request Overview
This PR updates the lrslib package from version 071b to version 073, applying autotools patches and adding a signal handler fix for GCC 15 compatibility.
Key changes:
- Updates package version to 073 and switches from a custom autotoolized fork to upstream source with patches
- Adds signal handler parameter fix for GCC 15 compatibility
- Updates build process to copy arithmetic headers and run autoreconf
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| build/pkgs/lrslib/spkg-install.in | Adds pre-build steps to copy arithmetic headers and prepare autotools build |
| build/pkgs/lrslib/patches/fix-signal-handlers.patch | Adds signal handler parameter signatures to fix GCC 15 compatibility |
| build/pkgs/lrslib/patches/autotools.patch | Adds comprehensive autotools build system configuration |
| build/pkgs/lrslib/package-version.txt | Updates version from 071b+autotools to 073 |
| build/pkgs/lrslib/checksums.ini | Updates checksums and upstream URL for version 073 |
| build/pkgs/lrslib/SPKG.rst | Updates documentation to reflect new patch approach and version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
cxzhong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the lrslib to 073 version with autotool patch and fix-signal-handler patch in gcc 15
📝 Checklist
⌛ Dependencies