Enable save/load to accept Path objects #41037
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
edgarcosta
commented
Oct 13, 2025
edgarcosta
commented
- The title is concise and informative.
- I have created tests covering the changes.
|
Documentation preview for this PR (built with commit 8885ac3; changes) is ready! 🎉 |
orlitzky
reviewed
Oct 13, 2025
9 tasks
|
Ok, it looks good to me, pending whatever those CI jobs are waiting for. |
|
@sagemath/core please approve workflows. (I guess this shows being added to sagemath/triage doesn't help with getting workflows approved at all.) |
user202729
reviewed
Oct 14, 2025
src/sage/misc/persist.pyx
Outdated
| """ | ||
| Append the .sobj extension to a filename if it doesn't already have it. | ||
| """ | ||
| s = os.fspath(s) # Convert path-like objects to strings |
There was a problem hiding this comment.
This line should be useless
user202729
reviewed
Oct 14, 2025
src/sage/misc/persist.pyx
Outdated
| return | ||
|
|
||
| filename = filename[0] | ||
| filename = os.fspath(filename) # Convert path-like objects to strings |
There was a problem hiding this comment.
the comment doesn't add anything meaningful to the code and is pure noise, delete.
This function needs doctest.
make sure if filename is originally a Path then the branch below with fetching URL is never executed.
edgarcosta
force-pushed
the
copilot/fix-save-path-object-issue
branch
from
f916d99 to
73d5d53
Compare
edgarcosta
force-pushed
the
copilot/fix-save-path-object-issue
branch
from
73d5d53 to
8885ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.