Skip to content

Add debian-forky to Meson CI #41029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Add debian-forky to Meson CI #41029

merged 1 commit into from
Oct 27, 2025

Conversation

@tobiasdiez
Copy link
Contributor

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez tobiasdiez changed the title Add debian-forky to meson CI Add debian-forky to Meson CI Oct 12, 2025
@github-actions
Copy link

Documentation preview for this PR (built with commit e294ba4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
Copy link
Contributor

Not directly related, but any chance we could get a minimal meson added to the CI? There's no hope for eclib without #40546, but it would be nice to ensure that the meson build is actually usable without the other optional-for-sagelib-only packages (rankwidth, brial, ???).

@tobiasdiez
Copy link
Contributor Author

Not directly related, but any chance we could get a minimal meson added to the CI? There's no hope for eclib without #40546, but it would be nice to ensure that the meson build is actually usable without the other optional-for-sagelib-only packages (rankwidth, brial, ???).

Should be relatively straightforward to create such a minimal config using conda; essentially only have to toggle these two lines:

sage/tools/update-conda.py

Lines 160 to 161 in 4e2319b

+ get_dev_dependencies(pyproject)
+ get_optional_dependencies(pyproject)

But I don't think I have the time to work on this in the foreseeable future.

Build is passing on debian, and mostly only a 'couple' of well-known doctests fail (related to maxima, lrcalc). Will look at this in a follow-up.

@tobiasdiez tobiasdiez marked this pull request as ready for review October 16, 2025 09:15
@cxzhong
Copy link
Contributor

cxzhong commented Oct 17, 2025

But I remember that we have a minimal linux CI test to build almostly all packages from spkg.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 20, 2025
b89df9e 
sagemathgh-41029: Add debian-forky to Meson CI
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#41029
Reported by: Tobias Diez
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 26, 2025
7494f85 
sagemathgh-41029: Add debian-forky to Meson CI
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#41029
Reported by: Tobias Diez
Reviewer(s):
@vbraun vbraun merged commit 190f165 into sagemath:develop Oct 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasdiez @orlitzky @cxzhong @vbraun