Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the latex representation of crystals tableaux #38764

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Oct 4, 2024

Fixes #38745

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#38339

Copy link

github-actions bot commented Oct 4, 2024

Documentation preview for this PR (built with commit 949f228; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu kwankyu marked this pull request as ready for review October 4, 2024 11:35
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems somewhat complicated to reuse s as a temporary variable compared to how it is used otherwise in the code. I think you should change the variable names around to avoid this.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 5, 2024

The dependency is only there for me and for reviewers on mac.

After review, I may remove it.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 5, 2024

It seems somewhat complicated to reuse s as a temporary variable compared to how it is used otherwise in the code. I think you should change the variable names around to avoid this.

OK. Done.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not sure about “a tex box” being correct (text?). Feel free to push a quick fix if this is indeed a typo. Afterwards (or if correct), please set to a positive review.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 6, 2024

It is "TeX box": https://en.wikibooks.org/wiki/LaTeX/Boxes

Thanks!

@kwankyu kwankyu changed the title Fix latex representation of crystals tableaux Fix the latex representation of crystals tableaux Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with view on MacOS
2 participants