-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the latex representation of crystals tableaux #38764
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 949f228; changes) is ready! 🎉 |
bdadc14
to
04b3417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems somewhat complicated to reuse s
as a temporary variable compared to how it is used otherwise in the code. I think you should change the variable names around to avoid this.
04b3417
to
88edf1a
Compare
The dependency is only there for me and for reviewers on mac. After review, I may remove it. |
OK. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am not sure about “a tex box” being correct (text?). Feel free to push a quick fix if this is indeed a typo. Afterwards (or if correct), please set to a positive review.
It is "TeX box": https://en.wikibooks.org/wiki/LaTeX/Boxes Thanks! |
Fixes #38745
📝 Checklist
⌛ Dependencies
#38339