Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create docker image #12

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

albertrdixon
Copy link
Contributor

@albertrdixon albertrdixon commented Oct 16, 2023

Story details: https://app.shortcut.com/gladly/story/169699

What

  • Create Dockerfile for building simple migrate image
  • Add Github Actions workflow for building and pushing the image to github container registry

Testing

  • Once built and pushed, pull and run the image with
docker run --rm -ti ghcr.io/sagansystems/migrate --help

@saganbot
Copy link

Storyhttps://app.shortcut.com/gladly/story/169699
Review Guidehttps://www.notion.so/gladly/Change-Approvals-at-Gladly-37814c3e0da8411985f6a1adaa2f64ad
RollbackFor repos on weekly release: roll back the release. For repos on continuous deployment (CD): revert the code change and deploy.

@saganbot
Copy link

saganbot commented Oct 16, 2023

Code review checklist

Code

  • Code is understandable and functions correctly
  • Code is appropriately covered by automated testing

Pull Request

Security

  • Does not check-in any secrets (e.g. passwords, api tokens)
  • Does not log any sensitive data (e.g. customer pii, passwords). This includes FullStory!

All items above must be checked off before the PR may be merged.

@albertrdixon albertrdixon requested review from egtann and a team October 18, 2023 20:58
@albertrdixon albertrdixon force-pushed the albertd/sc-169699/create-migrate-docker-image branch from ea11c88 to 8cceea2 Compare October 24, 2023 18:53
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entrypoint script handles the use case in which we must pass database client certificates as environment variables

Copy link
Contributor

@egtann egtann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@albertrdixon albertrdixon merged commit 4dc08bc into master Oct 24, 2023
@albertrdixon albertrdixon deleted the albertd/sc-169699/create-migrate-docker-image branch October 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants