Implement Project upload with V4 and selectable items. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkerssens
approved these changes
Mar 13, 2024
| time.Sleep(1 * time.Second) | ||
| tries++ | ||
| } else { | ||
| return errors.New("import task did not complete successfully. Status is \"" + importStatus.Status + "\". Please check the FME Flow web interface for the status of the import task") |
There was a problem hiding this comment.
Suggested change
| return errors.New("import task did not complete successfully. Status is \"" + importStatus.Status + "\". Please check the FME Flow web interface for the status of the import task") | |
| return errors.New("Import task did not complete successfully. Status is \"" + importStatus.Status + "\". Please check the FME Flow web interface for the status of the import task") |
There was a problem hiding this comment.
Go is actually picky about this and shouldn't start with a capital letter: https://go.dev/wiki/CodeReviewComments#error-strings
| if importStatus.Status == "imported" { | ||
| finished = true | ||
| } else if importStatus.Status != "importing" { | ||
| return errors.New("import task did not complete successfully. Please check the FME Flow web interface for the status of the import task") |
There was a problem hiding this comment.
Suggested change
| return errors.New("import task did not complete successfully. Please check the FME Flow web interface for the status of the import task") | |
| return errors.New("Import task did not complete successfully. Please check the FME Flow web interface for the status of the import task") |
| // validate that the selected items are the correct format | ||
| match, _ := regexp.MatchString(`^([^:,]+:[^:,]+,)*([^:,]+:[^:,]+)$`, f.selectedItems) | ||
| if !match { | ||
| return errors.New("invalid selected items. Must be a comma separated list of item ids and types. e.g. item1:itemtype1,item2:itemtype2") |
There was a problem hiding this comment.
Suggested change
| return errors.New("invalid selected items. Must be a comma separated list of item ids and types. e.g. item1:itemtype1,item2:itemtype2") | |
| return errors.New("Invalid selected items. Must be a comma separated list of item ids and types. e.g. item1:itemtype1,item2:itemtype2") |
| } | ||
| } | ||
| if !found { | ||
| return errors.New("selected item " + id + " (" + itemType + ") is not in the list of selectable items") |
There was a problem hiding this comment.
Suggested change
| return errors.New("selected item " + id + " (" + itemType + ") is not in the list of selectable items") | |
| return errors.New("Selected item " + id + " (" + itemType + ") is not in the list of selectable items") |
|
Thanks! I have made the changes suggested, with the exception of the error message capitalization: https://go.dev/wiki/CodeReviewComments#error-strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project upload was previously using the V3 API. This pull request will use the V4 API on builds that support it. This also allows for selectable items to be excluded if desired.