Ensure correct status code is returned in logs #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PooyaRaki
force-pushed
the
logErrorCode
branch
from
c17cbfb to
634ca5d
Compare
iamacook
reviewed
Jan 3, 2025
src/routes/common/interceptors/route-logger.interceptor.spec.ts
Outdated
Show resolved
Hide resolved
src/routes/common/interceptors/route-logger.interceptor.spec.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
changed the title
iamacook
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the correct status codes are returned and logged. Previously, an incorrect status code might have been recorded in the logs, which could lead to confusion or misinterpretation during debugging or monitoring.
This change improves the reliability and accuracy of application logs, aiding in better diagnostics and monitoring.
#1924
Changes