Implement AddressBookItem update #2149
Conversation
| authPayload: args.authPayload, | ||
| address: args.address, | ||
| }); | ||
| const addressBook = await this.datasource.getAddressBook({ |
There was a problem hiding this comment.
Question: Does it happen that the account is not found? If so, we shouldn't try to fetch the address book and update.
There was a problem hiding this comment.
it will throw here if there is no account so it won't try to fetch/update the addressbook
| @@ -14,91 +13,6 @@ describe('CreateAddressBookItemDtoSchema', () => { | |||
| expect(result.success).toBe(true); | |||
| }); | |||
|
|
|||
| it('should not verify a CreateAddressBookItemDto with a shorter name', () => { | |||
There was a problem hiding this comment.
Why are CreateAddressBookItemDto tests deleted?
There was a problem hiding this comment.
From a comment in a previous PR: #2151 (comment)
@iamacook suggested to just keep the tests for address book names in the address book name schema, so as not to test the same cases multiple times. I didn't remove them in that PR so removing them here.
| expect(result.success).toBe(true); | ||
| }); | ||
|
|
||
| it('should not verify an UpdateAddressBookItemDto with a string id', () => { |
There was a problem hiding this comment.
It seems to me that we are testing Zod validator, right?
| ]); | ||
| }); | ||
|
|
||
| it('should not verify an UpdateAddressBookItemDto with a malformed address', () => { |
There was a problem hiding this comment.
Here as well, it seems like we are testing the external validator library.
There was a problem hiding this comment.
I would keep this as it's important to ensure addresses come in correct.
| ]); | ||
| }); | ||
|
|
||
| it('should checksum the address of an UpdateAddressBookItemDto', () => { |
There was a problem hiding this comment.
Same as the previous comment.
There was a problem hiding this comment.
I would keep this as it's important to ensure addresses come in checksummed.
| @@ -107,61 +107,6 @@ describe('AddressBookSchema', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('should not verify an AddressBookItem with a shorter name', () => { | |||
There was a problem hiding this comment.
Question: Why are these tests deleted?
Summary
This PR adds the ability to update an
AddressBookItemby adding the following endpoint to the service:The endpoint is behind the
Accountsscope and requires authentication.Changes
UPDATEroute for deleting anAddressBookItem.