-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating new socket every time on connectAsync #40
base: master
Are you sure you want to change the base?
Conversation
Hi @angelix , I am not sure if it creates new connection everytime.... I am sure, it will close the previous socket (The reason why new one is created). Still, will look into it. Thank you for the PR. |
My server had a new connection for every connectAsync from the client. |
Hey, will be looking into it. Little busy those days ... |
Did you have the time to test this @sacOO7 ? Thanks |
Hi @sacOO7 , |
1 similar comment
Hi @sacOO7 , |
Hi @sacOO7 |
@sacOO7 ? :( |
Hey @angelix , will be looking into this |
For every call to connect/connectAsync there is a new ws socket created, leaving the previous one connected but orphaned.
This PR, allow only one instance of Socket to be actively connected at any time.