Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating new socket every time on connectAsync #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

angelix
Copy link
Contributor

@angelix angelix commented Aug 19, 2018

For every call to connect/connectAsync there is a new ws socket created, leaving the previous one connected but orphaned.
This PR, allow only one instance of Socket to be actively connected at any time.

@sacOO7
Copy link
Owner

sacOO7 commented Aug 19, 2018

Hi @angelix , I am not sure if it creates new connection everytime.... I am sure, it will close the previous socket (The reason why new one is created). Still, will look into it. Thank you for the PR.

@angelix
Copy link
Contributor Author

angelix commented Aug 19, 2018

My server had a new connection for every connectAsync from the client.
If you take a look at the code, it just replace ws with new Socket every time.
Thanks @sacOO7

@sacOO7
Copy link
Owner

sacOO7 commented Aug 21, 2018

Hey, will be looking into it. Little busy those days ...

@angelix
Copy link
Contributor Author

angelix commented Sep 15, 2018

Did you have the time to test this @sacOO7 ? Thanks

@angelix
Copy link
Contributor Author

angelix commented Oct 5, 2018

Hi @sacOO7 ,
When can you release a new version of the lib with the fixes?
Thanks

1 similar comment
@angelix
Copy link
Contributor Author

angelix commented Jan 6, 2019

Hi @sacOO7 ,
When can you release a new version of the lib with the fixes?
Thanks

@angelix
Copy link
Contributor Author

angelix commented Apr 18, 2019

Hi @sacOO7
It's being over 6 months for this PR to get merged or release a new version.
Do you need any help?

@angelix
Copy link
Contributor Author

angelix commented Aug 20, 2019

@sacOO7 ? :(

@sacOO7
Copy link
Owner

sacOO7 commented Apr 10, 2020

Hey @angelix , will be looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants