fix. Stylus button press changes tool to Eraser but do not erase. #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er do not work. This change allows switch to eraser by pressing and releasing stylus button (no more holding button), then erasing items work. Creates new preference, which can change default behavior of pressing button when pen is above screen. Solves issue saber-notes#1410
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 47.15% 47.15% -0.01%
==========================================
Files 114 114
Lines 9002 9018 +16
==========================================
+ Hits 4245 4252 +7
- Misses 4757 4766 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some styluses do not send move events when button is pressed. So Eraser do not work.
This change allows switch to eraser by pressing and releasing stylus button (no more holding button), then erasing items work.
Creates new preference, which can change default behavior of pressing button when pen is above screen.
Solves issue #1410